Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django-constance for dynamic settings #460

Draft
wants to merge 4 commits into
base: next
Choose a base branch
from
Draft

Conversation

krestenlaust
Copy link
Member

@krestenlaust krestenlaust commented May 19, 2024

Resolves #448

This is mostly to test whether adding constance as a dependency is justified

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.20%. Comparing base (294159e) to head (284be63).
Report is 9 commits behind head on next.

Current head 284be63 differs from pull request most recent head 448a221

Please upload reports for the commit 448a221 to get more accurate results.

Files Patch % Lines
stregsystem/views.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             next     #460       +/-   ##
===========================================
+ Coverage   53.49%   81.20%   +27.70%     
===========================================
  Files          33       33               
  Lines        4621     3112     -1509     
  Branches      274      377      +103     
===========================================
+ Hits         2472     2527       +55     
+ Misses       2097      546     -1551     
+ Partials       52       39       -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration that is hardcoded
1 participant